Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-13025] Allow users to set initial model in logistic regression #11459

Closed
wants to merge 1 commit into from
Closed

[SPARK-13025] Allow users to set initial model in logistic regression #11459

wants to merge 1 commit into from

Conversation

GayathriMurali
Copy link
Contributor

JIRA : SPARK - 13025

Modified access specifier to default(Public) to allow users to set initial model in logistic regression

@sethah
Copy link
Contributor

sethah commented Mar 2, 2016

Could you update the title with the Jira number? See here for more details.

@GayathriMurali GayathriMurali changed the title Allow users to set initial model in logistic regression [SPARK-13025] Allow users to set initial model in logistic regression Mar 2, 2016
@GayathriMurali
Copy link
Contributor Author

Can someone review this?

@jkbradley
Copy link
Member

This will be nice to have, but we should make initialModel be a Param

@GayathriMurali
Copy link
Contributor Author

@jkbradley initialModel is an instance of LogisticRegressionModel, I am not sure if I understand how to make it a Param?

@sethah
Copy link
Contributor

sethah commented Mar 7, 2016

Should this wait until PR-11119 is merged?

@GayathriMurali
Copy link
Contributor Author

@jkbradley are we waiting to get this merged until PR-11119?

@jkbradley
Copy link
Member

Sorry for the delayed review. I'm worried that these PRs to set the initial model may need to change significantly if we merge Estimator & Model: [https://issues.apache.org/jira/browse/SPARK-14033] After the merge, setting an initial model may make less sense, for it would then be easier to copy the initial model and set some Boolean parameter indicating that fitting should begin from the current model.

@SparkQA
Copy link

SparkQA commented Oct 11, 2016

Test build #66726 has finished for PR 11459 at commit ab05aa6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Hi all, where are we on this?

@sethah
Copy link
Contributor

sethah commented May 24, 2017

This can be closed.

@HyukjinKwon HyukjinKwon mentioned this pull request Jun 7, 2017
Closed
@asfgit asfgit closed this in b771fed Jun 8, 2017
@lanisyutin
Copy link

Hi, all, what about the status of this issue? why it was not merged? There are any ways to set initialWeights now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GayathriMurali @sethah @jkbradley @SparkQA @HyukjinKwon @lanisyutin